Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource go back path #3415

Closed
wants to merge 2 commits into from
Closed

Conversation

Nevelito
Copy link
Contributor

@Nevelito Nevelito commented Nov 13, 2024

Description

add page number to edit path

Fixes # (issue)
issue: #1555

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Before changes:
Recording_1.webm

After changes:
Recording_2.webm

Copy link

codeclimate bot commented Nov 13, 2024

Code Climate has analyzed commit 16fd6c1 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution @Nevelito

Preserving all referrer parameters across two requests to address this issue feels somewhat excessive. It might be worth exploring a local storage-based approach, though it comes with its own challenges, such as resetting the page state when navigating to the index via the sidebar or a direct link.

Let's put this PR on hold for now until we figure out the best way to tackle it

Copy link
Contributor

github-actions bot commented Dec 4, 2024

This PR has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label Dec 4, 2024
@Paul-Bob
Copy link
Contributor

Closing since this was already implemented

@Paul-Bob Paul-Bob closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants